-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Source-Salesforce #1351
Added Source-Salesforce #1351
Conversation
Fixed flow.yaml file configs
Remote Repo URL: [email protected]:airbytehq/airbyte.git Source name: 0f887bc Source Commit ID: 0f887bc143ee14726983816c9972b9398e500bc0 Source Repo Prefix: airbyte-integrations/connectors/source-salesforce/ Import Path: source-salesforce/ License Type: MIT License Path: airbyte-integrations/connectors/source-salesforce/metadata.yaml git-merge-subpath: 0f887bc143ee14726983816c9972b9398e500bc0 airbyte-integrations/connectors/source-salesforce source-salesforce
Thanks @Luishfs -- I started a Slack conversation about schemas in My only other comment is that there's a bit more cleanup to be done regarding removing files related to Airbyte integration tests that aren't relevant for us, and consolidating all unit tests into a single |
Removed integration tests Due to the source-salesforce connector having a big number of schema files AND the connector not running capture tests, the necessity of schema files is undermined. Since that, this commit rebases into removing those
At this point in time, all unit_tests shall pass, only snapshot ones "fail"
@jgraettinger Thanks for the review! |
Description:
(Describe the high level scope of new or changed features)
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
@jgraettinger
This change is