Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Source-Salesforce #1351

Closed
wants to merge 12 commits into from
Closed

Added Source-Salesforce #1351

wants to merge 12 commits into from

Conversation

Luishfs
Copy link
Collaborator

@Luishfs Luishfs commented Mar 8, 2024

Description:

(Describe the high level scope of new or changed features)

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)
@jgraettinger


This change is Reviewable

Fixed flow.yaml file configs
Remote Repo URL: [email protected]:airbytehq/airbyte.git
Source name: 0f887bc
Source Commit ID: 0f887bc143ee14726983816c9972b9398e500bc0
Source Repo Prefix: airbyte-integrations/connectors/source-salesforce/
Import Path: source-salesforce/
License Type: MIT
License Path: airbyte-integrations/connectors/source-salesforce/metadata.yaml

git-merge-subpath: 0f887bc143ee14726983816c9972b9398e500bc0 airbyte-integrations/connectors/source-salesforce source-salesforce
@Luishfs Luishfs marked this pull request as ready for review March 8, 2024 20:57
@jgraettinger
Copy link
Member

Thanks @Luishfs -- I started a Slack conversation about schemas in acmeCo/ which we can discuss there. I'll ask that you re-write the commit history to clean up those files pending that discussion.

My only other comment is that there's a bit more cleanup to be done regarding removing files related to Airbyte integration tests that aren't relevant for us, and consolidating all unit tests into a single tests/ directory. Please reference source-asana/ or this PR for examples of what remains of an imported connector after cleanup. Thanks

Removed integration tests

Due to the source-salesforce connector having a big number of schema files AND
the connector not running capture tests, the necessity of schema files is undermined.
Since that, this commit rebases into removing those
At this point in time, all unit_tests shall pass, only snapshot ones "fail"
@Luishfs
Copy link
Collaborator Author

Luishfs commented Mar 11, 2024

@jgraettinger Thanks for the review!
As of now, i've made all changes you requested. All unit_tests are passing, but the snapshot ones.
Could you give me the next steps? I know snapshots should not match since they are largely different, but from what i saw most mismatches are reguarding schema_type pattern & the _meta column being added, so i've updated them.
You can check the diff on the next commit
Also updated spec's config and descriptions

@Luishfs Luishfs self-assigned this Mar 11, 2024
@Luishfs Luishfs closed this Mar 11, 2024
@Luishfs Luishfs reopened this Mar 11, 2024
@Luishfs Luishfs closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants